Remove creation of cluster role in service account reconcile of connect cluster #3296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on #3086
What changed?
Use exisiting cluster role instead of creating a new one for the service account
Why was this change made?
To reduce number of resources created when an existing resource can be used
How was this change implemented?
cluster-admin
when creating the cluster role bindingHow did you validate the change?
Given a hub and spoke cluster, runnning the following command and checking for the created resources in the spoke cluster and secret with kubeconfig in the hub cluster
note: won't work directly if the spoke cluster is a local kind cluster because the IP will be localhost
there tests that fail without the change?
Release notes
Documentation Changes
Other follow ups