Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typescript project settings affecting local dev #3303

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

jpellizzari
Copy link
Contributor

Fixes some IDE errors that were noisy after our directory structure migration.

Related to #3263

@jpellizzari jpellizzari requested a review from foot September 6, 2023 17:38
@jpellizzari jpellizzari added the exclude from release notes Use this label to exclude a PR from the release notes label Sep 6, 2023
@yiannistri
Copy link
Collaborator

@jpellizzari I noticed that our Tiltfile needs updating as well, could we update it as part of this PR?

@jpellizzari
Copy link
Contributor Author

@jpellizzari I noticed that our Tiltfile needs updating as well, could we update it as part of this PR?

Not sure what needs to be updated there. @yiannistri Feel free to commit to this branch.

@yiannistri
Copy link
Collaborator

Apologies, I was wrong. I was looking at an older version of Tiltfile but then realised it was already updated as part of #3263

@foot
Copy link
Collaborator

foot commented Sep 7, 2023

Fixed up some Makefile stuff too thanks @opudrovs !

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙏

@opudrovs
Copy link
Contributor

opudrovs commented Sep 7, 2023

@foot great, thank you!

@jpellizzari jpellizzari force-pushed the jp-ts-project-settings branch from 4be23ca to 9877295 Compare September 7, 2023 17:29
@jpellizzari jpellizzari merged commit 67b92ec into main Sep 7, 2023
@jpellizzari jpellizzari deleted the jp-ts-project-settings branch September 7, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants