Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tabs style at workspaces and make them consistent with the rest of the application #3344

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix tabs style at workspaces and make them consistent with the rest of the application #3344

merged 2 commits into from
Sep 13, 2023

Conversation

ahussein3
Copy link
Contributor

Closes #3925

What changed?

  • Remove styles that override the main tabs style.
  • Add attribute to button icon to match how we add pre-icon to button.

@ahussein3 ahussein3 requested a review from foot September 12, 2023 14:12
@ahussein3 ahussein3 added enhancement New feature or request ui_triage Cross-team/project UI issues for triage and removed ui_triage Cross-team/project UI issues for triage labels Sep 12, 2023
@ahussein3 ahussein3 assigned ahussein3 and unassigned jpellizzari Sep 12, 2023
@jpellizzari
Copy link
Contributor

@ahussein3 Can you add a before-after image to your PR?

@ahussein3
Copy link
Contributor Author

Before:
image

After:
image

foot
foot reviewed Sep 13, 2023
View reviewed changes
ui/src/components/Workspaces/WorkspaceDetails/WorkspaceHeaderSection.tsx
@@ -10,6 +10,7 @@ function WorkspaceHeaderSection({ name, namespaces, clusterName }: Workspace) {
return (
<Flex column gap="16">
<Button
startIcon={<Icon type={IconType.FilterIcon} size="base" />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 , nice.

foot
foot reviewed Sep 13, 2023
View reviewed changes
ui/src/components/Workspaces/WorkspaceStyles.ts Outdated
@@ -6,15 +6,6 @@ export const CustomSubRouterTabs = styled(SubRouterTabs)(props => ({
'.MuiTabs-root': {
marginTop: props.theme.spacing.medium,
width: '100%',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of these styles too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will give it a look right a way

foot
foot approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling fixes that remove styles are the best

@ahussein3 ahussein3 merged commit b14865a into main Sep 13, 2023
@ahussein3 ahussein3 deleted the FixWorkSpaceTabs branch September 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@jpellizzari jpellizzari Awaiting requested review from jpellizzari

Assignees

@ahussein3 ahussein3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahussein3 @jpellizzari @foot