Make objects request not block the Applications and Source UI loading. #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinaGoaga
approved these changes
Sep 14, 2023
jpellizzari
force-pushed
the
2769-apps-blocking
branch
from
42986bf to
86d8867
Compare
jpellizzari
force-pushed
the
2769-apps-blocking
branch
from
86d8867 to
5cae8f8
Compare
One issue with the `enabled` flag is that it is set based on the `useFeatureFlags()` hook, which first returns false, and then true once the request completes.
jpellizzari
force-pushed
the
2769-apps-blocking
branch
from
5cae8f8 to
c5838eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2769
Removes the "blocking" behavior that showed a loading spinner even if the query service results are ready.
One issue with the
enabledflag on the hook is that it is set based on theuseFeatureFlags()hook, which first returns false, and then true once the request completes.