Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target echo-ldflags to fix the release and gitops version command #3363

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Sep 15, 2023

Closes #3343

What changed?
Add back target echo-ldflags printing CMD_GITOPS_LDFLAGS variable to pass them to goreleaser that will build and publish gitops-ee binary

Why was this change made?

To both fix the original issue and the release

How did you validate the change?

  • Explain how a reviewer can verify the change themselves
  1. Fork the repo ( ex https://github.com/enekofb/weave-gitops-enterprise)
  2. add the change in this PR
  3. tweak the release workflow to execute the failing parts
  4. tag your change with va.b.c and execute the release workflow
    You should see that
  • the make target file has been executed correctly
  • goreleaser has the values propagated
Screenshot 2023-09-15 at 08 16 06
  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests
  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?
    Not required

Release notes

No

Documentation Changes

No

Other follow ups

No

@enekofb enekofb added the bug Something isn't working label Sep 15, 2023
@enekofb enekofb changed the title add target echo-ldflags using variable to pass them to goreleaser tha… add target echo-ldflags to fix the release and gitops version command Sep 15, 2023
@yiannistri yiannistri merged commit f230869 into main Sep 15, 2023
@yiannistri yiannistri deleted the add-ldflags branch September 15, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enterprise gitops cli advertised as version v0.0.0
2 participants