Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Use ImageAutomation components from OSS and remove duplicates from EE #3372

Merged
merged 4 commits into from
Oct 1, 2023

Conversation

TheGostKasper
Copy link
Contributor

Closes #3339

What changed?
Remove duplicate ImageAutomation components from EE and use the one imported from OSS

Why was this change made?

It looks like the Image Automation section in OSS is copy/pasted from EE - Sync/Suspend has been added there, and hopefully this is as easy as deleting the code in EE and importing it from OSS instead.

@TheGostKasper TheGostKasper added the enhancement New feature or request label Sep 19, 2023
@TheGostKasper TheGostKasper marked this pull request as draft September 19, 2023 12:44
@TheGostKasper TheGostKasper marked this pull request as ready for review September 27, 2023 17:45
@opudrovs
Copy link
Contributor

The ui-unit-tests step is failing.

@TheGostKasper TheGostKasper marked this pull request as draft September 27, 2023 18:26
Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, corresponding pages work with my image automations YAML applied to the cluster as expected.

@TheGostKasper TheGostKasper marked this pull request as ready for review October 1, 2023 08:58
@TheGostKasper TheGostKasper merged commit 30621d5 into main Oct 1, 2023
@TheGostKasper TheGostKasper deleted the 3339 branch October 1, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sync/Suspend to Image Automation section in EE
2 participants