a set of internal docs that to complete the picture about weave gitops engineering #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enekofb
added
the
exclude from release notes
enekofb
force-pushed
the
internal-docs
branch
from
e6ee096 to
fb8c85c
Compare
squaremo
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Nice one bringing this all together @enekofb. I have just cosmetic things to suggest -- in fact mainly just capitalisation :-D I would suggest being more precise about the benefits of using golang -- I've made specific suggestions for that in the comments, in two places.
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
Co-authored-by: Michael Bridgen <[email protected]>
enekofb
force-pushed
the
internal-docs
branch
from
f625c80 to
e596135
Compare
|
Thanks, Michael for your review and on-point comments. Have updated also the google doc reflecting the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added some documentation to give an overview on some engineering topics like cicd, code quality and security, dataflows, etc ...
Why was this change made?
It was requested to document some of these aspects for external consumption. I guess that adding it here would help with similar future needs and iterations.
How was this change implemented?
Documentation added based to the best of my knowledge and restricted to the time we got (~ a day or so).
Other follow ups
TBD