Bring PR Preview to the GitOps section #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinaGoaga
added
exclude from release notes
… update to use loading state in button rather than page loader to match sync and suspend
…ave-gitops-enterprise into update-gitops-form-section
ahussein3
approved these changes
Oct 2, 2023
…ave-gitops-enterprise into update-gitops-form-section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3377
What changed?
Actual state:
https://github.com/weaveworks/weave-gitops-enterprise/assets/35202557/5bc2b051-6f8d-465c-a37c-5e4fee93c0a4
Why was this change made?
This will indicate to the user that the section affects the resulting PR (which repo to create a PR for, what to put in the PR title and so on).
Other follow ups
The PR Preview sections are slightly different across the forms so there is a bit of repetition in the code. Make follow up ticket to address and perhaps move this section into the GitOps component.