Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auto merge option from add and update profiles #3417

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Remove auto merge option from add and update profiles #3417

merged 2 commits into from
Oct 2, 2023

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Sep 29, 2023 •
edited
Loading

Closes #1233

@AlinaGoaga AlinaGoaga added the enhancement New feature or request label Sep 29, 2023
@AlinaGoaga AlinaGoaga changed the title Remove auto merge option from add and update profiles Remove auto merge option from add and update profiles / add dry run to add profiles Sep 29, 2023
@AlinaGoaga AlinaGoaga changed the title Remove auto merge option from add and update profiles / add dry run to add profiles Remove auto merge option from add and update profiles Sep 29, 2023
@AlinaGoaga AlinaGoaga added exclude from release notes Use this label to exclude a PR from the release notes and removed enhancement New feature or request labels Sep 29, 2023
@AlinaGoaga AlinaGoaga marked this pull request as ready for review September 29, 2023 13:41
sarataha
sarataha approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@AlinaGoaga AlinaGoaga merged commit 5f747ce into main Oct 2, 2023
@AlinaGoaga AlinaGoaga deleted the cli-flags branch October 2, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarataha sarataha sarataha approved these changes

@foot foot foot approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI] The flag options are not consistent for add cluster and profile sub commands
3 participants
@AlinaGoaga @foot @sarataha