Ensure indexer hits are unique #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
jp-label-query
branch
from
be36a7e to
e942d0c
Compare
opudrovs
approved these changes
Oct 2, 2023
@jpellizzari could you expand on the background of having two hits? |
enekofb
approved these changes
Oct 3, 2023
One hit on the “all terms” query, and another on the “all unstructured” query. |
Got it now, thanks! |
jpellizzari
force-pushed
the
jp-label-query
branch
from
e942d0c to
2fdb9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3402
Ensures that indexer hits are unique. Since we have two records for each object, one with unstructured and one without, we have two hits on the same object if no query params are supplied.