Adds AutomatedClusterDiscovery to the explorer #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alfaris we need an icon to represent the Cluster Discovery in the side Navigation. And @bigkevmcd Suggested that we Use the K8s Icon. Can you provide the K8s icon in the same format as the navigation icons so we can add it? |
|
@alfaris we found this image that will suit better in contect if you can make this as icon.
|
I've made icon similar to what you were looking for, but consistent with our sidebar style
Here is the SVG code for it <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M18.99 5V10.5H4.98999V5H18.99ZM18.99 4H4.98999C4.43999 4 3.98999 4.45 3.98999 5V10.5C3.98999 11.05 4.43999 11.5 4.98999 11.5H18.99C19.54 11.5 19.99 11.05 19.99 10.5V5C19.99 4.45 19.54 4 18.99 4Z" fill="#737373"/>
<path d="M6.98999 8.75C7.54227 8.75 7.98999 8.30228 7.98999 7.75C7.98999 7.19772 7.54227 6.75 6.98999 6.75C6.43771 6.75 5.98999 7.19772 5.98999 7.75C5.98999 8.30228 6.43771 8.75 6.98999 8.75Z" fill="#737373"/>
<path d="M4.98999 13.5V19H17H18L18.99 20H4.98999C4.43999 20 3.98999 19.55 3.98999 19V13.5C3.98999 12.95 4.43999 12.5 4.98999 12.5H12.8066L12 13.5H4.98999Z" fill="#737373"/>
<path d="M6.98999 17.25C7.54227 17.25 7.98999 16.8023 7.98999 16.25C7.98999 15.6977 7.54227 15.25 6.98999 15.25C6.43771 15.25 5.98999 15.6977 5.98999 16.25C5.98999 16.8023 6.43771 17.25 6.98999 17.25Z" fill="#737373"/>
<path d="M14.98 13.0601C15.51 13.0601 16.01 13.2701 16.38 13.6401C17.15 14.4101 17.15 15.6701 16.38 16.4401C16.01 16.8101 15.51 17.0201 14.98 17.0201C14.45 17.0201 13.95 16.8101 13.58 16.4401C12.81 15.6701 12.81 14.4101 13.58 13.6401C13.95 13.2701 14.45 13.0601 14.98 13.0601ZM14.98 12.0601C14.22 12.0601 13.45 12.3501 12.87 12.9301C11.71 14.0901 11.71 15.9801 12.87 17.1401C13.45 17.7201 14.21 18.0101 14.98 18.0101C15.75 18.0101 16.51 17.7201 17.09 17.1401C18.25 15.9801 18.25 14.0901 17.09 12.9301C16.51 12.3501 15.75 12.0601 14.98 12.0601Z" fill="#737373"/>
<path d="M17 17.0601L19.71 19.7701" stroke="#737373" stroke-miterlimit="10"/>
</svg> |
foot
commented
Nov 8, 2023
foot
commented
Nov 8, 2023
cmd/clusters-service/app/server.go
Outdated
| err = coreCfg.PrimaryKinds.Add("GitOpsSet", gitopssetsv1alpha1.GroupVersion.WithKind("GitOpsSet")) | ||
| if err != nil { | ||
| return fmt.Errorf("could not add GitOpsSet to primary kinds: %w", err) | ||
| } |
There was a problem hiding this comment.
Can remove gitopssets I think
foot
commented
Nov 8, 2023
foot
force-pushed
the
adds-cluster-reflector-controller
branch
from
1b23ec5 to
85aed09
Compare
foot
commented
Nov 9, 2023
- Feature flag the cluster discovery page in the UI - Adds support for syncing/inv/suspend via the OSS endpoints
foot
force-pushed
the
adds-cluster-reflector-controller
branch
from
40d2d22 to
0e7ae4c
Compare
foot
commented
Nov 10, 2023
ahussein3
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3408
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes
Other follow ups