Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datatable tests #3577

Merged
merged 6 commits into from
Nov 7, 2023
Merged

fix datatable tests #3577

merged 6 commits into from
Nov 7, 2023

Conversation

TheGostKasper
Copy link
Contributor

@TheGostKasper TheGostKasper commented Nov 1, 2023

Follow up to #3427
Because of the recent cleanup DataTable PR merged in OSS,it's possible that unrelated tests in EE started failing so This PR is for fixing it

@TheGostKasper TheGostKasper added bug Something isn't working area/ui labels Nov 1, 2023
@opudrovs
Copy link
Contributor

opudrovs commented Nov 2, 2023

A snapshot test is failing.

@opudrovs
Copy link
Contributor

opudrovs commented Nov 2, 2023

And could you please rebase on the main branch? Some breaking changes could have been merged recently.

@opudrovs
Copy link
Contributor

opudrovs commented Nov 5, 2023

The ui-unit-tests step is still failing.

@TheGostKasper
Copy link
Contributor Author

TheGostKasper commented Nov 6, 2023

still waiting OSS version to be updated and then all tests will pass
image

@TheGostKasper TheGostKasper merged commit d73a499 into main Nov 7, 2023
10 checks passed
@TheGostKasper TheGostKasper deleted the followUp-datatable-tests branch November 7, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants