fix: Remove GitOps Run components from WGE #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
added
the
exclude from release notes
yiannistri
force-pushed
the
update-weave-gitops
branch
from
14346aa to
29bf1cd
Compare
…0.7.0 to v0.9.3 and remove replace directive for sigs.k8s.io/controller-runtime v0.14.6
yiannistri
force-pushed
the
update-weave-gitops
branch
from
0d9acac to
839ee6c
Compare
yiannistri
requested review from
waleedhammam,
enekofb,
bigkevmcd and
yitsushi
yitsushi
approved these changes
Nov 6, 2023
waleedhammam
reviewed
Nov 6, 2023
waleedhammam
approved these changes
Nov 7, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3514
What changed?
Removed GitOps Run-related code from WGE. In doing so, I've had to also bump the following dependencies:
Why was this change made?
GitOps Run has been deprecated and WGE still references old code.
How did you validate the change?
Explain how a reviewer can verify the change themselves
Integration tests -- what is covered, what cannot be covered;
or, explain why there are no new tests
No integration tests needed, this PR removes obsolete code.
Unit tests -- what is covered, what cannot be covered; are
there tests that fail without the change?
No unit tests needed, this PR removes obsolete code.
Release notes
TBD
Documentation Changes
Already made.
Other follow ups
None.