Enable "multi-tenancy" lookup of terraform objects #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Search across multiple namespaces using the OSS querier instead of doing a cluster-level (kubectl get -A) query which tenants won't have permissions to do.
bigkevmcd
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/weaveworks/weave-gitops-interlock/issues/432
What changed?
Search across multiple namespaces using the OSS querier instead of doing a cluster-level (
kubectl get -A) query which tenants won't have permissions to do.Why was this change made?
So that tenants can see terraform objects in namespaces they have access to, instead of seeing a "you don't have permissions to list terraform objects at the cluster scope"
How was this change implemented?
false->trueHow did you validate the change?
tilt+ Setup OIDC against dex-01 and added cluster-admin rolebinding to default/flux-systemRelease notes
Documentation Changes
Other follow ups