Support removing columns from the explorer table #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We now provide the default columns that can be filtered / added to etc
- Clean up sorting logic - Don't use sortValue to derive the column id, its used to generate a value to sort by
foot
commented
Nov 9, 2023
| // Override column name to maintain compatibility with the DataTable sync buttons | ||
| if (col === 'clusterName') { | ||
| col = 'cluster'; | ||
| } |
There was a problem hiding this comment.
Not sure about this code? 🤔
There was a problem hiding this comment.
If the sync buttons work with the new changes, this should be okay.
foot
added
the
exclude from release notes
|
@jpellizzari strong thoughts here? Feels like its getting a bit too DataTabley in a way. |
jpellizzari
approved these changes
Nov 10, 2023
| // Override column name to maintain compatibility with the DataTable sync buttons | ||
| if (col === 'clusterName') { | ||
| col = 'cluster'; | ||
| } |
There was a problem hiding this comment.
If the sync buttons work with the new changes, this should be okay.
I think DataTable is being replaced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactoring the
<Explorer />fields a bit.extraColumns, you pass in all the columns and user can filter them as they likeidfield to columns to allow easier filtering of columnsidfield can be used to simplify ordering logic a little bitWhy was this change made?
So we can remove some fields (tenancy), in the
ClusterDiscoverywork ongoing..How was this change implemented?
How did you validate the change?
yarn tsc+yarn lint+yarn testall still passtilt upand sorting in explorer etc all still worksConcerns