Add types to the GetKubeconfigRequest #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If it changes in the future we'll get a nice type error
foot
force-pushed
the
add-types-to-get-kubeconfig
branch
from
f65c4b5 to
a835aea
Compare
foot
added
the
exclude from release notes
ahussein3
approved these changes
Nov 13, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why was this change made?
So we get a nice type error if this API endpoint changes in the future
How was this change implemented?
Required<>to make all the params inGetKubeconfigRequestrequired (the proto-ts-gen stuff makes everything optional)How did you validate the change?
tilt up, capv cluster, Get kubeconfig still worksRelease notes
Documentation Changes
Other follow ups