Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restored enabled behaviour until we dont refactor its usage #3651

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Nov 20, 2023

What changed?

  • restored enabled logic for inputs
  • removed some other debugging messages
  • adding test case and logic for interactive update of cluster user step

Why was this change made?

  • we removed it without refactoring the steps using is so we broke the contract

How did you validate the change?

  • Explain how a reviewer can verify the change themselves
    Run acceptance tests for bootstrapping and see them passing

Release notes

No

Documentation Changes

No

Other follow ups

We should refactor along the way steps using enabled (but that is something that we already knew)

@enekofb enekofb requested a review from waleedhammam November 20, 2023 17:10
@enekofb enekofb added the bug Something isn't working label Nov 20, 2023
@enekofb enekofb requested a review from Samra10 November 20, 2023 17:44
@enekofb enekofb marked this pull request as ready for review November 20, 2023 17:46
@enekofb enekofb force-pushed the bootstrapping-flux-bug branch from f531175 to 2c81f8a Compare November 21, 2023 08:46
@enekofb enekofb force-pushed the bootstrapping-flux-bug branch from cb2e570 to 51f8417 Compare November 21, 2023 11:54
@enekofb enekofb requested a review from waleedhammam November 21, 2023 11:55
@enekofb enekofb requested a review from waleedhammam November 21, 2023 12:17
Copy link
Contributor

@waleedhammam waleedhammam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@enekofb enekofb merged commit 3829d88 into main Nov 21, 2023
10 checks passed
@enekofb enekofb deleted the bootstrapping-flux-bug branch November 21, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants