Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Explorer. GitOpsSets/Templates pages uses the Explorer by default #3652

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Nov 20, 2023

What changed?

  1. Turn the explorer on by default.
  2. Switch the default GitOpsSet listing endpoint that the UI uses from the OSS querier to the Explorer querier.
  3. Switch the default GitOpsTemplates listing endpoint that the UI uses from the Management querier to the Explorer querier.

Why was this change made?

GitOpsSets recently dropped all its own endpoints. Including the "List GitOpSets" endpoint that used the Management Querier.

Now the gitopssets can either use:

  1. The OSS querier which has issues w/ multi-tenancy (the current default)
  2. The Explorer querier w/ better multi-tenancy support and faster etc etc (the new default set in this PR)

How was this change implemented?

Changes to values.yaml which the user can revert if they need to.

How did you validate the change?

  • tilt up, check that gitopssets still work okay

Release notes

( Add me to the next release notes under Highlights section)

Highlights

Explorer enabled by default. GitOpsSets and GitOpsTemplates uses Explorer by default.

Explorer is enabled by default for GitOpsSets and GitOpsTemplates. This improves the pages with:

  • Showing GitOpsSets on multiple clusters
  • Faster page load and full-text search for enhanced .

You could control where Explorer is enabled via configuration.

By default, this release configuration is:

explorer:
  enabled: true
  enabledFor:
    - gitopssets
    - templates

In case you want to use the old experience, for example for GitOpsTemplates, override the default values with:

explorer:
  enabled: true
  enabledFor:
    - gitopssets

Documentation Changes

Other follow ups

@foot foot added the enhancement New feature or request label Nov 21, 2023
@foot foot changed the title enabled explorer by default as well as gitopsssets and templates so w… GitOpsSets UI querying uses the Explorer by default Nov 21, 2023
@foot foot marked this pull request as ready for review November 21, 2023 12:12
@foot foot changed the title GitOpsSets UI querying uses the Explorer by default GitOpsSets/Templates UI querying uses the Explorer by default Nov 21, 2023
@foot foot changed the title GitOpsSets/Templates UI querying uses the Explorer by default Enable explorer. GitOpsSets/Templates pages uses the Explorer by default Nov 21, 2023
@foot foot changed the title Enable explorer. GitOpsSets/Templates pages uses the Explorer by default Enable Explorer. GitOpsSets/Templates pages uses the Explorer by default Nov 21, 2023
@foot
Copy link
Collaborator

foot commented Nov 21, 2023

Nice one ⭐ , great PR description.

@enekofb enekofb force-pushed the enable-explorer-default branch from 4b1102e to 90b9efa Compare November 22, 2023 14:50
@enekofb enekofb force-pushed the enable-explorer-default branch from 90b9efa to 1b3fd80 Compare November 22, 2023 15:00
@enekofb enekofb merged commit 451fe87 into main Nov 22, 2023
9 of 10 checks passed
@enekofb enekofb deleted the enable-explorer-default branch November 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants