Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onboarding CLI: fix flux private key password #3665

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Conversation

waleedhammam
Copy link
Contributor

@waleedhammam waleedhammam commented Nov 22, 2023

Closes #3663

What changed?

  • Update private key password flag according to flux
  # Run bootstrap for a Git repository with a passwordless private key
  flux bootstrap git --url=ssh://[email protected]/repository.git --private-key-file=<path/to/private.key> --path=clusters/my-cluster

  # Run bootstrap for a Git repository with a private key and password
  flux bootstrap git --url=ssh://[email protected]/repository.git --private-key-file=<path/to/private.key> --password=<password> --path=clusters/my-cluster

Why was this change made?

How was this change implemented?

  • change flag --gpg-passphrase to use password --password in bootstrap CLI flux

How did you validate the change?

  • Explain how a reviewer can verify the change themselves
    Start interactive installation with ssh repo URL / Non-interactive with passing ssh creds
go run main.go bootstrap  --private-key=<path> --private-key-password=<password>
  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests

ran the acceptance test

  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?

couldn't be tested with unit test as it includes running flux binary / requires git creds

Release notes

Documentation Changes

Other follow ups

@waleedhammam waleedhammam added bug Something isn't working exclude from release notes Use this label to exclude a PR from the release notes labels Nov 22, 2023
@waleedhammam waleedhammam requested a review from enekofb November 22, 2023 09:19
@waleedhammam waleedhammam removed the bug Something isn't working label Nov 22, 2023
@waleedhammam waleedhammam changed the title fix flux private key password onboarding CLI: fix flux private key password Nov 22, 2023
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please share a bit of the background around the library change ... just thinking in terms of version compatibility

also please add to the PR the validation done

@waleedhammam
Copy link
Contributor Author

waleedhammam commented Nov 22, 2023

@enekofb updated and tested acceptance test case

@waleedhammam waleedhammam merged commit 8f5c1ca into main Nov 23, 2023
10 checks passed
@waleedhammam waleedhammam deleted the 3663-fix-pk-password branch November 23, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onboarding CLI: ssh private key password is not working
2 participants