Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay Explorer query input focus until drawer animation is complete #3676

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jpellizzari
Copy link
Contributor

@jpellizzari jpellizzari commented Nov 27, 2023

Closes #3634

Fixes an issue where the FilterDialog would have a weird expansion animation. The root cause was the auto-focus logic triggering the input component to expand in width for some reason (this is a Material behavior).

See the original issue for videos.

@jpellizzari jpellizzari added the bug Something isn't working label Nov 27, 2023
@jpellizzari jpellizzari requested a review from opudrovs November 27, 2023 20:50
Copy link
Contributor

@opudrovs opudrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 It's great that you've found the cause of this behavior.

@jpellizzari jpellizzari merged commit 6cebf66 into main Nov 28, 2023
11 checks passed
@jpellizzari jpellizzari deleted the 3634-filter-dialog branch November 28, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Filters dialog animation
2 participants