Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes bootstrapping networking to use clusterip and other modes via release values #3685

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Dec 1, 2023

Closes #3495

What changed?

Implemented weaveworks/weave-gitops-private#139:

  • Changes bootstrapping default networking access to just clusterip
  • Added other configuration to the helm release values

Why was this change made?

First implementation didn't allow extensibility and took a few assumptions that were not necessarily generally applicable.

How was this change implemented?

  • Apart the changes in the description earlier, introduced git and flux clients to be able to do unit testing with fakeclients.
  • Cleaned also references to unused configuration options like domainXX

How did you validate the change?

  • Explain how a reviewer can verify the change themselves

Run the acceptance test or run the command manually

  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests

No new integration points added.

  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?

  • added for the install step

Release notes

Documentation Changes

weaveworks/weave-gitops#4153

Other follow ups

No

@enekofb enekofb added the enhancement New feature or request label Dec 1, 2023
@enekofb enekofb changed the title Wge 3495 bootstrapping networking changes bootstrapping networking to use clusterip and other modes via release values Dec 1, 2023
@enekofb enekofb marked this pull request as ready for review December 1, 2023 15:24
pkg/bootstrap/steps/install_wge.go Outdated Show resolved Hide resolved
pkg/bootstrap/steps/install_wge.go Outdated Show resolved Hide resolved
pkg/bootstrap/steps/install_wge.go Outdated Show resolved Hide resolved
@enekofb enekofb requested a review from waleedhammam December 4, 2023 08:43
@enekofb enekofb force-pushed the wge-3495-bootstrapping-networking branch from b232c08 to d62473f Compare December 4, 2023 09:16
Copy link
Contributor

@waleedhammam waleedhammam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM / Tested the flow
It's also necessary to update the documentation in this release for this part

@enekofb enekofb merged commit 13cc4b4 into main Dec 4, 2023
10 checks passed
@enekofb enekofb deleted the wge-3495-bootstrapping-networking branch December 4, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap cli: iterate support for wge expose mechanism
2 participants