-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes bootstrapping networking to use clusterip and other modes via release values #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enekofb
changed the title
Wge 3495 bootstrapping networking
changes bootstrapping networking to use clusterip and other modes via release values
Dec 1, 2023
waleedhammam
reviewed
Dec 3, 2023
enekofb
force-pushed
the
wge-3495-bootstrapping-networking
branch
from
December 4, 2023 09:16
b232c08
to
d62473f
Compare
waleedhammam
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM / Tested the flow
It's also necessary to update the documentation in this release for this part
waleedhammam
reviewed
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3495
What changed?
Implemented weaveworks/weave-gitops-private#139:
Why was this change made?
First implementation didn't allow extensibility and took a few assumptions that were not necessarily generally applicable.
How was this change implemented?
git
andflux
clients to be able to do unit testing with fakeclients.How did you validate the change?
Run the acceptance test or run the command manually
or, explain why there are no new tests
No new integration points added.
Unit tests -- what is covered, what cannot be covered; are
there tests that fail without the change?
added for the install step
Release notes
Documentation Changes
weaveworks/weave-gitops#4153
Other follow ups
No