explorer default sort by score #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enekofb
force-pushed
the
wge-3627-explorer-sort-score
branch
from
64f34b9 to
0adf3dd
Compare
jpellizzari
approved these changes
Dec 5, 2023
enekofb
force-pushed
the
wge-3627-explorer-sort-score
branch
from
0adf3dd to
fae56bc
Compare
enekofb
commented
Dec 6, 2023
| }, | ||
| want: []string{"someName", "otherName"}, | ||
| want: []string{"someName"}, |
There was a problem hiding this comment.
Reducing the number of results given that without any ordering, the default is score, and given * there is no indication of quality ... we have both results with score of 1 ... which we cannot depend on its order reliability for asserting ...
given the test is that we could query by * ... having one or more than one might not matter much
jpellizzari
approved these changes
Dec 6, 2023
…and we cannot deterministically rely on order
enekofb
force-pushed
the
wge-3627-explorer-sort-score
branch
from
ee3e091 to
6dcb162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3627
What changed?
Why was this change made?
How did you validate the change?
Tilt on the branch and search for flux-system you should see now flux-system objects ranking first
Integration tests -- what is covered, what cannot be covered;
or, explain why there are no new tests
Unit tests -- what is covered, what cannot be covered; are
there tests that fail without the change?
Added unit test to ensure deterministic search by scoring behaviour
Release notes
Documentation Changes
Other follow ups