Fixes Terraform table/list page crashing #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Optimistic fix" for https://github.com/weaveworks/weave-gitops-interlock/issues/618
As we cannot actually repro this issue.
What changed?
Why was this change made?
Customer was seeing an
Invalid Dateerror message, crashing the terraform list page.How was this change implemented?
Looking at the provided stack trace and guessing where we might avoid the exception they are experiencing.
How did you validate the change?
Added unit tests for this particular case. Assuming this is the place they are seeing the exception though.