Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

coverage reporting not restricted to weave packages #1524

Closed
rade opened this issue Oct 12, 2015 · 2 comments
Closed

coverage reporting not restricted to weave packages #1524

rade opened this issue Oct 12, 2015 · 2 comments
Assignees
@rade
Labels
bug
Milestone
1.2.0

Comments

@rade
Copy link
Member

rade commented Oct 12, 2015

the coverage reporting in our build takes in all packages containing 'weaveworks', which is way too lax.

Found in #1438 (comment)
@rade rade added the bug label Oct 12, 2015
@rade rade self-assigned this Oct 12, 2015
@rade rade closed this as completed in a31ccef Oct 12, 2015
@rade
Copy link
Member Author

rade commented Oct 12, 2015

well, that didn't work. because the tools git submodule has a similar grep. And there we can't just hardcode the package prefix since scope uses it too. grrr.

@rade rade reopened this Oct 12, 2015
@rade
Copy link
Member Author

rade commented Oct 12, 2015

Fixed in weaveworks/build-tools@a286dda, hopefully.

@rade rade closed this as completed Oct 12, 2015
rade added a commit that referenced this issue Oct 12, 2015
@rade
a better way to restrict coverage
1d00bdd 
this better fixes #1524.
@rade rade added this to the 1.2.0 milestone Oct 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rade rade

Labels
bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@rade