This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
prevent ConnectionMaker.ConnectionTerminated race #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the ConnectionMaker to maintain its own knowledge of the local connections, based on events emitted in the connection lifecycle. Fixes #1478.
rade
force-pushed
the
1478-cm-termination-race
branch
from
0f84911 to
0e32d5a
Compare
|
I wonder whether the benefit/risk ratio is too low for this to go into 1.1. |
|
I don't think the benefit is high, as a duplicate connection will be torn down, and if a stale error kills a good connection it will re-try shortly. What is the risk? Did you see this happen for real? |
Simply the complexity of the change, which is in an area that traditionally has seen quite a few problems.
No. |
|
There's some more tidying up of status reporting that I want to do... -> re-assignig to myself. |
|
I am going to re-base this on master. closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1478.