This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 673
Hold DNS entries sorted case-insensitively until just before sending #1611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkAndPanic(CaseSensitive(g.Entries)) | ||
defer func() { checkAndPanic(CaseSensitive(g.Entries)) }() | ||
checkAndPanic(CaseInsensitive(g.Entries)) | ||
defer func() { checkAndPanic(CaseInsensitive(g.Entries)) }() |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
needs to be branched off 1.2 |
I reckon the gossip data decoding code should be moved near the encoding code. e.g.
and then call it from
(I think that works) |
the unit tests failed. |
reduce mock gossip timer to 2 seconds to trigger more often during tests.
… when we re-sort case-sensitively in Encode()
bboreham
force-pushed
the
1603-resort-in-encode
branch
from
October 30, 2015 11:37
edc8bb7
to
fa2a5ab
Compare
Wrong branch; replaced by #1615 |
}} | ||
|
||
require.Equal(t, expected, g1) | ||
} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sorting when creating the outbound
GossipData
object, we sort inEncode()
.Fixes #1603 and #1610