This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Probe whether the kernel has ODP vxlan support #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if !odp_supported { | ||
| if err != nil { | ||
| Log.Fatal(err) | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
It's possible to build that kernel with openvswitch, and vxlan, but without the vport_vxlan module that glues them together. And at least one distro has actually done this.
|
This got merged into master, but the issue it is meant to be resolving has a 1.2.1 milestone. |
|
Hmm. But the issue indicates that something did get merged into 1.2. @awh please explain what happened here. |
Well, the commit message says that, but it's actually a merge into master. Except it also show up on the 1.2 branch. What happened? |
I merged it into 1.2 on the command line, then 1.2->master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to build that kernel with openvswitch, and vxlan, but
without the vport_vxlan module that glues them together. And at
least one distro has actually done this.
Addresses #1599.