Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Forbid traffic to the Weave port from containers #1670

Merged
merged 1 commit into from
Nov 26, 2015

Conversation

inercia
Copy link
Contributor

@inercia inercia commented Nov 11, 2015

Fixes #1634

@inercia inercia force-pushed the issues/1634-block-6783-6784 branch from 524154a to 0d76817 Compare November 13, 2015 08:33
@bboreham
Copy link
Contributor

Please rebase so the tests run against Docker 1.9

@inercia
Copy link
Contributor Author

inercia commented Nov 13, 2015

Please rebase so the tests run against Docker 1.9

Blocked by #1675

@inercia inercia force-pushed the issues/1634-block-6783-6784 branch from 0d76817 to b48058c Compare November 16, 2015 10:28
@awh awh self-assigned this Nov 17, 2015
@awh
Copy link
Contributor

awh commented Nov 17, 2015

Apologies, the original issue was a bit muddled - it stated we needed to block UDP 6783/6784 but we also need to block TCP 6783 too (I've updated the subject to reflect this). This PR blocks TCP & UDP 6783 - can we block $PORT+1 (the fast datapath vxlan port) as well?

@awh awh assigned inercia and unassigned awh Nov 17, 2015
@inercia
Copy link
Contributor Author

inercia commented Nov 19, 2015

@awh So, just to be sure we are on the same page, we need to block 6783/tcp, 6783/udp and 6784/udp...

Make sure we have the Docker bridge IP before adding/removing iptables rules
@inercia inercia force-pushed the issues/1634-block-6783-6784 branch from b48058c to ddb390d Compare November 19, 2015 13:46
@inercia inercia assigned awh and unassigned inercia Nov 19, 2015
awh added a commit that referenced this pull request Nov 26, 2015
Forbid traffic to the Weave port from containers
@awh awh merged commit ba6f8da into master Nov 26, 2015
@awh awh added this to the 1.4.0 milestone Nov 26, 2015
@awh awh deleted the issues/1634-block-6783-6784 branch November 30, 2015 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants