Automatically symlink /var/run/*.sock sockets to /var/run/weave/*.sock

[paulbellamy]

Uses approach 1 to fix #1694

Comments on approach vs 2, would be great.

[awh]

Can you think of any compelling reasons why we would choose option 2? I think I prefer option 1.

[paulbellamy]

Option 2 makes for more consistent handling of unix sockets. It means we're not special-casing sockets in /var/run, they're handled the same as anywhere else. But it is ~30-70 more lines of code (because running docker containers from go is more work than from cli)

[paulbellamy]

Ok, test is failing because docker unix socket is only accessible to root:docker on gce.

[awh]

Option 2 makes for more consistent handling of unix sockets. It means we're not special-casing sockets in /var/run, they're handled the same as anywhere else. But it is ~30-70 more lines of code (because running docker containers from go is more work than from cli)

Another idea - how about having the weave script symlink all unix:/// args (anywhere in the filesystem - no special casing) to /var/run/weave/weave.sock and then have the proxy listen to that single socket?

[awh]

If someone does

$ weave launch-proxy -H unix:///var/run/test.sock

would they find the path returned by this

$ weave env
export DOCKER_HOST=unix:///var/run/weave/test.sock ORIG_DOCKER_HOST=

surprising?

[paulbellamy]

Their level of surprise probably depends on what they expected it to return.

Edit: Just actually read the result, yeah that's probably not right.