This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Don't remove weave network on plugin shutdown because it bricks Docker 1.10 #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awh
added a commit
that referenced
this pull request
Feb 9, 2016
Don't remove weave network on plugin shutdown because it bricks Docker 1.10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1959.
This code was originally added because leaving the weave network in-situ while Docker restarted would cause errors and delay Docker startup. Unfortunately, somewhere along the line to Docker 1.10 the opposite situation came into effect, only it's now much worse.
The weave script already tries to remove the
weavenetwork onstoporreset, so this extra call should be unnecessary - we start the plugin with--restart=alwaysso it should come up after Docker restart.