This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Process DiscardingFlowOp correctly in FastDatapath send() #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nil FlowOp check in collectFlowOps was not addressed with the introduction of DiscardingFlowOp. This meant that DiscardingFlowOps produced in the router core would get handled by fastdp as if they were foreign FlowOps, preventing flow creation and so leading to unwarranted ODP misses. To fix this, collectFlowOps cannot simply eliminate FlowOps for which Discards() is true, because it's true for odpFlowKeyFlowOp. So the Discards() case has to be handled in FastDatapath send().
|
Fixes #2003. |
|
LGTM, but I think we may prefer to create a 1.4 patch release. |
If I tried to follow the formalities, I'd probably forget something important and embarrass myself, so I'll leave that part to your team. This PR is just a way to present the fix. |
|
Thanks; I'll do the merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nil FlowOp check in collectFlowOps was not addressed with the
introduction of DiscardingFlowOp. This meant that DiscardingFlowOps
produced in the router core would get handled by fastdp as if they were
foreign FlowOps, preventing flow creation and so leading to unwarranted
ODP misses.
To fix this, collectFlowOps cannot simply eliminate FlowOps for which
Discards() is true, because it's true for odpFlowKeyFlowOp. So the
Discards() case has to be handled in FastDatapath send().