Change weavedb from an emptyDir to a hostPath volume #2967

bboreham · 2017-05-16T13:58:34Z

emptyDir has the same lifetime as the pod, whereas we want our persistence to extend past that, e.g. when Weave Net is upgraded.

We assume that /var/lib is writable.

Fixes #2610

marccarre · 2017-05-16T15:44:17Z

As discussed on Slack, this requires a similar change in the Launch Generator.
EDIT: done in weaveworks/launch-generator/pull/107

marccarre · 2017-05-16T15:44:37Z

Should we add a step to delete this directory in the tests?

bboreham · 2017-05-16T16:01:58Z

Should we add a step to delete this directory in the tests?

I guess so; from the point of view of ensuring that we test the same thing each time.
Ideally we would extend the tests to do some sort of 'delete pods and restart' to check persistence worked.

marccarre · 2017-05-16T16:03:39Z

Ideally we would extend the tests to do some sort of 'delete pods and restart' to check persistence worked.

Agreed 👍

prog/weave-kube/weave-daemonset-k8s-1.6.yaml

@@ -102,7 +102,8 @@ spec:
          type: spc_t
      volumes:
        - name: weavedb
-          emptyDir: {}
+          hostPath:
+            path: /var/lib/weave-net


bboreham · 2017-05-17T09:16:19Z

Should we add a step to delete this directory in the tests?

I now think weave reset should clear out this persistence directory; this will help, e.g. if someone needs to move a peer from one cluster to another.

(it isn't easy to run weave reset in a Kubernetes context, but that's a different problem)

EmptyDir has the same lifetime as the pod, whereas we want our persistence to extend past that, e.g. when Weave Net is upgraded. `weave reset` cleans out the file. We assume that /var/lib is writable.

marccarre

LGTM.

marccarre · 2017-05-18T09:08:59Z

@brb, what do you think of these latest changes? (I'll wait for your final review before I merge)

weave

@@ -1634,6 +1634,7 @@ case "$COMMAND" in
        protect_against_docker_hang
        VOLUME_CONTAINERS=$(docker ps -qa --filter label=weavevolumes)
        [ -n "$VOLUME_CONTAINERS" ] && docker rm -v $VOLUME_CONTAINERS  >/dev/null 2>&1 || true
+        rm -f $HOST_ROOT/var/lib/weave/weave-netdata.db >/dev/null 2>&1 || true


marccarre

LGTM.

bboreham added this to the 2.0 milestone May 16, 2017

brb reviewed May 17, 2017

View reviewed changes

bboreham force-pushed the issues/2610-host-volume branch from 0a8eb32 to 73d5204 Compare May 17, 2017 10:24

Change weavedb from an emptyDir to a hostPath volume

bebaa48

EmptyDir has the same lifetime as the pod, whereas we want our persistence to extend past that, e.g. when Weave Net is upgraded. `weave reset` cleans out the file. We assume that /var/lib is writable.

bboreham force-pushed the issues/2610-host-volume branch from 73d5204 to bebaa48 Compare May 17, 2017 12:38

marccarre approved these changes May 18, 2017

View reviewed changes

brb reviewed May 19, 2017

View reviewed changes

marccarre approved these changes May 23, 2017

View reviewed changes

marccarre merged commit 0c89bbb into master May 23, 2017

marccarre deleted the issues/2610-host-volume branch May 23, 2017 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change weavedb from an emptyDir to a hostPath volume #2967

Change weavedb from an emptyDir to a hostPath volume #2967

bboreham commented May 16, 2017

marccarre commented May 16, 2017 •

edited

Loading

marccarre commented May 16, 2017

bboreham commented May 16, 2017

marccarre commented May 16, 2017 •

edited

Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

bboreham commented May 17, 2017

marccarre left a comment

marccarre commented May 18, 2017

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

marccarre left a comment

Change weavedb from an emptyDir to a hostPath volume #2967

Change weavedb from an emptyDir to a hostPath volume #2967

Conversation

bboreham commented May 16, 2017

marccarre commented May 16, 2017 • edited Loading

marccarre commented May 16, 2017

bboreham commented May 16, 2017

marccarre commented May 16, 2017 • edited Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

bboreham commented May 17, 2017

marccarre left a comment

Choose a reason for hiding this comment

marccarre commented May 18, 2017

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

marccarre left a comment

Choose a reason for hiding this comment

marccarre commented May 16, 2017 •

edited

Loading

marccarre commented May 16, 2017 •

edited

Loading