Merge pull request #61 from weaviate/support-biu-nlp-abstract-sim-model

Add support for Bar-Ilan University NLP Lab models
weaviate · May 29, 2023 · 47cac3d · 47cac3d
2 parents ffe4aba + 02dae4f
commit 47cac3d
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 13 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -54,6 +54,10 @@ jobs:
             model_tag_name: google-flan-t5-base
           - model_name: google/flan-t5-large
             model_tag_name: google-flan-t5-large
+          - model_name: biu-nlp/abstract-sim-sentence
+            model_tag_name: biu-nlp-abstract-sim-sentence
+          - model_name: biu-nlp/abstract-sim-query
+            model_tag_name: biu-nlp-abstract-sim-query
     env:
       LOCAL_REPO: transformers-inference
       REMOTE_REPO: semitechnologies/transformers-inference
@@ -73,16 +77,16 @@ jobs:
           password: ${{secrets.DOCKER_PASSWORD}}
       - name: Build and test
         run: |
-          cicd/build.sh || exit 1
-          cicd/test.sh || exit 1
+          cicd/build.sh
+          cicd/test.sh
       - name: Deploy
         if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
         env:
           DOCKER_USERNAME: ${{secrets.DOCKER_USERNAME}}
           DOCKER_PASSWORD: ${{secrets.DOCKER_PASSWORD}}
         run: |
           export GIT_TAG=${GITHUB_REF##*/}
-          cicd/docker_push.sh || exit 1
+          cicd/docker_push.sh
   build-custom-image:
     name: Build custom image
     runs-on: ubuntu-latest
@@ -107,4 +111,4 @@ jobs:
           DOCKER_PASSWORD: ${{secrets.DOCKER_PASSWORD}}
         run: |
           export GIT_TAG=${GITHUB_REF##*/}
-          cicd/build_custom_base.sh || exit 1
+          cicd/build_custom_base.sh
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,5 @@
 __pycache__
 models
 nltk_data
+.venv/
+.vscode/
diff --git a/README.md b/README.md
@@ -44,6 +44,9 @@ The pre-built models include:
 |`facebook/dpr-question_encoder-single-nq-base` ([Info](https://huggingface.co/facebook/dpr-question_encoder-single-nq-base))|`semitechnologies/transformers-inference:facebook-dpr-question_encoder-single-nq-base`|
 |`vblagoje/dpr-ctx_encoder-single-lfqa-wiki` ([Info](https://huggingface.co/vblagoje/dpr-ctx_encoder-single-lfqa-wiki))|`semitechnologies/transformers-inference:vblagoje-dpr-ctx_encoder-single-lfqa-wiki`|
 |`vblagoje/dpr-question_encoder-single-lfqa-wiki` ([Info](https://huggingface.co/vblagoje/dpr-question_encoder-single-lfqa-wiki))|`semitechnologies/transformers-inference:vblagoje-dpr-question_encoder-single-lfqa-wiki`|
+|Bar-Ilan University NLP Lab Models|
+|`biu-nlp/abstract-sim-sentence` ([Info](https://huggingface.co/biu-nlp/abstract-sim-sentence))|`semitechnologies/transformers-inference:biu-nlp-abstract-sim-sentence`|
+|`biu-nlp/abstract-sim-query` ([Info](https://huggingface.co/biu-nlp/abstract-sim-query))|`semitechnologies/transformers-inference:biu-nlp-abstract-sim-query`|
 
 
 The above image names always point to the latest version of the inference

diff --git a/cicd/build.sh b/cicd/build.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -e
+set -eou pipefail
 
 local_repo=${LOCAL_REPO?Variable LOCAL_REPO is required}
 model_name=${MODEL_NAME?Variable MODEL_NAME is required}

diff --git a/cicd/build_custom_base.sh b/cicd/build_custom_base.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -e
+set -eou pipefail
 
 function build() {
   docker build -f custom.Dockerfile -t "custom-base" .

diff --git a/cicd/docker_push.sh b/cicd/docker_push.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -e pipefail
+set -eou pipefail
 
 # Docker push rules
 # If not on main

diff --git a/cicd/test.sh b/cicd/test.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -e
+set -eou pipefail
 
 local_repo=${LOCAL_REPO?Variable LOCAL_REPO is required}
 

diff --git a/requirements.txt b/requirements.txt
@@ -1,6 +1,6 @@
-transformers==4.27.2
-fastapi==0.95.0
-uvicorn==0.21.1
+transformers==4.29.2
+fastapi==0.95.2
+uvicorn==0.22.0
 nltk==3.8.1
-torch==2.0.0
-sentencepiece==0.1.97
+torch==2.0.1
+sentencepiece==0.1.99