Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate /vectors route to remove 307 redirects, fixes #34 #43

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

trengrj
Copy link
Member

@trengrj trengrj commented Jan 16, 2023

Currently, Weaviate is configured to POST to /vectors however the module listens on /vectors/ causing many 307 HTTP redirects:

INFO:     127.0.0.1:59650 - "POST /vectors HTTP/1.1" 307 Temporary Redirect
INFO:     127.0.0.1:59651 - "POST /vectors HTTP/1.1" 307 Temporary Redirect
INFO:     127.0.0.1:59662 - "POST /vectors/ HTTP/1.1" 200 OK
INFO:     127.0.0.1:59663 - "POST /vectors/ HTTP/1.1" 200 OK

This PR adds a duplicate route to remove the 307. It is non breaking as we leave the original route alone (though we should deprecate it).

@antas-marcin antas-marcin merged commit b62e425 into main Jan 16, 2023
@antas-marcin antas-marcin deleted the trengrj-307 branch January 16, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants