Add support for ONNX runtime #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antas-marcin
force-pushed
the
add-support-for-onnx-runtime
branch
2 times, most recently
from
cd77973 to
5f57ea5
Compare
antas-marcin
force-pushed
the
add-support-for-onnx-runtime
branch
from
5f57ea5 to
2436eeb
Compare
antas-marcin
force-pushed
the
add-support-for-onnx-runtime
branch
from
f6dae49 to
f5bbf90
Compare
antas-marcin
changed the title
tsmith023
approved these changes
Dec 1, 2023
| def download_onnx_model(model_name: str, model_dir: str): | ||
| # Download model and tokenizer | ||
| onnx_path = Path(model_dir) | ||
| ort_model = ORTModelForFeatureExtraction.from_pretrained(model_name, from_transformers=True) |
There was a problem hiding this comment.
I'm surprised that this is the optimum.onnxruntime class to use for loading embedding models with ONNX but it seems to be used elsewhere for the same task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ONNX runtime.
Adds 5 models capable running using ONNX vectorizer:
BAAI/bge-small-en- 384dBAAI/bge-small-en-v1.5- 384dBAAI/bge-base-en- 768dBAAI/bge-base-en-v1.5- 768dsentence-transformers/all-MiniLM-L6-v2- 384d