Add stroke-dashoffset handler #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancutter
reviewed
Nov 14, 2016
| @@ -71,4 +71,8 @@ suite('dimension-handler', function() { | |||
| assert.isUndefined(webAnimations1.consumeLengthOrPercent('(10px)')); | |||
| assert.isUndefined(webAnimations1.consumeLengthOrPercent('calc(10px,10px)')); | |||
| }); | |||
| test('interpolation of more specific properties', function() { | |||
| assert.equal(webAnimations1.propertyInterpolation('strokeDashoffset', '10px', '50px')(0.25), '20px'); | |||
There was a problem hiding this comment.
This should be able to interpolate multi valued values e.g. '10px 20px' to '50px 60px'.
If it doesn't can you file an issue to add support for it? I won't block this patch on supporting that right away.
lgtm.
There was a problem hiding this comment.
Turns out stroke-dashoffset does not support multiple values; that's stroke-dasharray. Submitting as-is.
|
+1 for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a rebase of #85 onto the new development branch, and also adds a test. The patch fixes #84.