feat(rspack-provider): support security.checkSyntax in Rspack #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a558145 The changes in this PR will be included in the next version bump. This PR includes changesets to release 208 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3685 +/- ##
==========================================
+ Coverage 57.59% 58.17% +0.57%
==========================================
Files 672 643 -29
Lines 17794 17190 -604
Branches 3876 3751 -125
==========================================
- Hits 10249 10000 -249
+ Misses 6934 6589 -345
+ Partials 611 601 -10 ☔ View full report in Codecov by Sentry. |
chenjiahan
reviewed
May 23, 2023
packages/builder/builder-rspack-provider/src/types/config/security.ts
Outdated
Show resolved
Hide resolved
chenjiahan
reviewed
May 23, 2023
chenjiahan
reviewed
May 23, 2023
chenjiahan
approved these changes
May 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
related issue: web-infra-dev/rspack#3147
related issue: #3634
🤖 Generated by Copilot at 9848c5c
This pull request refactors the
checkSyntaxplugin to make it reusable across different builder packages. It moves the plugin and its dependencies from@modern-js/builder-webpack-providerto@modern-js/builder-shared, and updates the imports and types accordingly. It also adds thecheckSyntaxoption to the security config for Rspack, which is a tool for building React Server Components. The option allows users to enable or disable the syntax analysis feature for the output files.Details
🤖 Generated by Copilot at 9848c5c
checkSyntaxplugin to support syntax checking for React Server Components (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)checkSyntaxplugin frompackages/builder/builder-webpack-provider/src/webpackPlugins/CheckSyntaxPlugintopackages/builder/builder-shared/src/plugins/CheckSyntaxPluginand update imports and types accordingly (link, link, link, link, link, link, link, link, link)checkSyntaxoption to the default security config for Rspack inpackages/builder/builder-rspack-provider/src/config/defaults.tsand apply the plugin to the default plugins for Rspack inpackages/builder/builder-rspack-provider/src/shared/plugin.ts(link, link)packages/builder/builder-rspack-provider/src/types/config/security.tsto import the shared security config from@modern-js/builder-shared(link)checkSyntaxplugin to the@modern-js/builder-sharedpackage inpackages/builder/builder-shared/package.json(link, link)applymethod of thecheckSyntaxplugin inpackages/builder/builder-shared/src/plugins/CheckSyntaxPlugin/index.tsto make it compatible with both webpack and Rspack (link)checkSyntaxplugin from the@modern-js/builder-sharedpackage inpackages/builder/builder-shared/src/plugins/index.ts(link)checkSyntaxto themockBuilderPluginshelper function inpackages/builder/builder-shared/src/test-stub/helper.ts(link)securityproperty of the shared normalized config type required inpackages/builder/builder-shared/src/types/config/index.ts(link)checkSyntaxoption inpackages/builder/builder-shared/src/types/config/security.tsand add the option to the shared security config interface (link, link)checkSyntaxplugin to the plugins type inpackages/builder/builder-shared/src/types/plugin.ts(link)checkSyntaxplugin from the@modern-js/builder-webpack-providerpackage inpackages/builder/builder-webpack-provider/package.json(link, link, link)Related Issue
Checklist
pnpm run change.