Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace btsm with tsm #3740

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented May 23, 2023

Summary

The btsm package was forked from tsm to add support for dynamic import, now tsm has added the official support, so we can switch back to `tsm.

🤖 Generated by Copilot at d3cc4d1

Updated the testing and scripting dependencies to use tsm and tsx packages that support TypeScript 4.5 and ESM modules. Renamed and modified the test files and scripts accordingly.

Details

🤖 Generated by Copilot at d3cc4d1

  • Replace btsm with tsm to support TypeScript 4.5 and ESM modules (link, link, link, link, link, link)
  • Update tsx to 3.12.7 to use the latest TypeScript compiler with ESM support (link, link, link)
  • Rename btsm.test.ts to tsm.test.ts and update the -r argument to test the new package (link, link)
  • Use tsx instead of btsm for the codemod script in scripts/codemod/package.json (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

⚠️ No Changeset found

Latest commit: 9775f28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.57 🎉

Comparison is base (99693f0) 57.59% compared to head (9775f28) 58.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
+ Coverage   57.59%   58.17%   +0.57%     
==========================================
  Files         672      643      -29     
  Lines       17794    17189     -605     
  Branches     3876     3750     -126     
==========================================
- Hits        10249     9999     -250     
+ Misses       6934     6589     -345     
+ Partials      611      601      -10     

see 265 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenjiahan chenjiahan merged commit 76a3c51 into web-infra-dev:main May 23, 2023
@chenjiahan chenjiahan deleted the tsm_0523 branch May 23, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants