-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export @remix-run/router cjs instead of react-router-dom #4011
Conversation
🦋 Changeset detectedLatest commit: 93a99ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 216 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4011 +/- ##
==========================================
- Coverage 57.59% 57.30% -0.30%
==========================================
Files 672 645 -27
Lines 17794 17527 -267
Branches 3876 3841 -35
==========================================
- Hits 10249 10044 -205
+ Misses 6934 6859 -75
- Partials 611 624 +13 ☔ View full report in Codecov by Sentry. |
docs: change changeset
Summary
🤖 Generated by Copilot at 555c7f4
This pull request fixes the cjs export of
@remix-run/router
for node environments in two packages, and adds some todo comments to refactor the data loading logic in the cli and server packages.Details
🤖 Generated by Copilot at 555c7f4
@remix-run/router
cjs instead ofreact-router-dom
for node environments (link, link, link)createRequest.ts
toruntime/
directory and removematchEntry
andbundle
logic from server data loader (link, link)Related Issue
Checklist
pnpm run change
.