lint

crates/rspack_core/src/concatenated_module.rs

@@ -780,7 +780,7 @@ impl Module for ConcatenatedModule {
           if let Some(namespace_object_name) = namespace_object_name {
             all_used_names.insert(namespace_object_name.clone());
             info.namespace_object_name = Some(namespace_object_name.clone());
-            top_level_declarations.insert(namespace_object_name.into());
+            top_level_declarations.insert(namespace_object_name);
           }
           // dbg!(info.module, &info.internal_names);
         }

crates/rspack_plugin_javascript/src/runtime.rs

@@ -10,7 +10,7 @@ use rustc_hash::FxHashSet as HashSet;
 
 use crate::{JsPlugin, RenderJsModuleContentArgs};
 
-pub fn render_chunk_modules<'a>(
+pub fn render_chunk_modules(
   compilation: &Compilation,
   chunk_ukey: &ChunkUkey,
   ordered_modules: Vec<&BoxModule>,
@@ -24,7 +24,7 @@ pub fn render_chunk_modules<'a>(
       compilation.options.is_new_tree_shaking() || include_module_ids.contains(&module.identifier())
     })
     .filter_map(|module| {
-      render_module(compilation, chunk_ukey, &module, all_strict, true)
+      render_module(compilation, chunk_ukey, module, all_strict, true)
         .transpose()
         .map(|result| result.map(|(s, f, a)| (module.identifier(), s, f, a)))
     })

crates/rspack_plugin_library/src/assign_library_plugin.rs

@@ -314,7 +314,7 @@ impl JavascriptModulesPluginPlugin for AssignLibraryJavascriptModulesPluginPlugi
     };
     if self.options.declare
       || matches!(self.options.prefix, Prefix::Global)
-      || self.options.prefix.len() > 0
+      || !self.options.prefix.is_empty()
       || options.name.is_none()
     {
       return Ok(None);