fix: react refresh in async entrypoint #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
team
underfin
approved these changes
Jul 10, 2023
underfin
approved these changes
Jul 10, 2023
|
!canary |
|
0.2.5-canary-32a0280-20230710091317 |
|
@ahabhgk we should add the breaking change notice in description, so other should know about it |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix react refresh error when importing a react component in worker module
before the react refresh runtime is added by prepending additional entry, but worker chunk is a async entrypoint, so in async entrypoint will loose the react refresh runtime because you can't prepend entry for async entrypoint
now we inject the react refresh runtime by
builtins.provideto make sure every module using react will have the react refresh runtimeTest Plan
packages/playground/cases/react/worker