Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: external callbacks receive contextInfo.issuer #7210

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat: external callbacks receive contextInfo.issuer #7210

merged 1 commit into from
Jul 18, 2024
+227 −4

Conversation

fi3ework
Copy link
Member

Summary

Align with https://webpack.js.org/configuration/externals/#function, type here https://github.com/webpack/webpack/blob/main/types.d.ts#L8192

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d77b591
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6698d6a7f3d3060008e346ed

@fi3ework fi3ework requested a review from ahabhgk July 18, 2024 09:20
@ahabhgk ahabhgk merged commit 25e44b9 into web-infra-dev:main Jul 18, 2024
29 checks passed
@chenjiahan chenjiahan mentioned this pull request Jul 26, 2024
Merged
@SoonIter SoonIter mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fi3ework @ahabhgk