Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: speedup free disk space job #7241

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

xc2
Copy link
Collaborator

@xc2 xc2 commented Jul 20, 2024

Summary

Refer to jlumbroso/free-disk-space#26 for more

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 214a87b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669cb900fe44060008ec3f95

@xc2 xc2 force-pushed the ci-quick-free-disk-space branch from 23c3d76 to d1486d2 Compare July 20, 2024 08:15
@xc2 xc2 closed this Jul 20, 2024
@xc2 xc2 reopened this Jul 20, 2024
@xc2 xc2 marked this pull request as ready for review July 20, 2024 12:10
@xc2 xc2 requested a review from jerrykingxyz as a code owner July 20, 2024 12:10
@xc2 xc2 requested a review from SyMind July 20, 2024 12:10
@chenjiahan
Copy link
Member

Nice 👍🏻 Can you see how much faster Rspack's CI will be?

@xc2
Copy link
Collaborator Author

xc2 commented Jul 20, 2024

Nice 👍🏻 Can you see how much faster Rspack's CI will be?

We expect a reduction of ~1min regardless of the repo.

The actual execution time varies based on the availability of CPU and IO resources.

@chenjiahan
Copy link
Member

Cool 😄

@chenjiahan
Copy link
Member

The Test Linux / Test Node 18 CI failed, but I think it is unrelated to this change...

@xc2
Copy link
Collaborator Author

xc2 commented Jul 20, 2024

The Test Linux / Test Node 18 CI failed, but I think it is unrelated to this change...

Awaiting #7240 to be approved or suggested a better solution.

@xc2 xc2 force-pushed the ci-quick-free-disk-space branch from 26145a8 to 214a87b Compare July 21, 2024 07:30
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chenjiahan chenjiahan merged commit 5100174 into web-infra-dev:main Jul 21, 2024
29 checks passed
@xc2 xc2 deleted the ci-quick-free-disk-space branch July 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants