refactor(types): remove @ts-expect-error in Compiler and MultiCompiler #7824
+105
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Sep 9, 2024
SoonIter
force-pushed
the
remove-all-expect-error
branch
from
462a02b to
b292be6
Compare
chenjiahan
previously approved these changes
Sep 9, 2024
SoonIter
force-pushed
the
remove-all-expect-error
branch
from
bc26980 to
f012f04
Compare
The devServer e2e tests only stuck in the github-action machine |
SoonIter
force-pushed
the
remove-all-expect-error
branch
from
096f0c2 to
7fcfc55
Compare
chenjiahan
approved these changes
Sep 10, 2024
|
rebased on main to pass the CI |
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#4640
#7225
Checklist