feat: support attributes for ESM external module #8422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: feature
✅ Deploy Preview for rspack canceled.
|
fi3ework
force-pushed
the
external-attributes
branch
4 times, most recently
from
d6ef409 to
e9caab6
Compare
fi3ework
force-pushed
the
external-attributes
branch
from
e9caab6 to
5b46e39
Compare
LingyuCoder
approved these changes
Nov 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix web-infra-dev/rslib#413.
Synced webpack test functions to align with https://github.com/webpack/webpack/blob/a24e4fdd6e83992c7b017cfabafa82da72a1e4ce/test/ConfigTestCases.template.js. The diff on GitHub is terrible, here's my local semantic diff:
The webpack test was wrong before, but it can run under the webpack test simulated runtime, while Rspack doesn't fully aligned the test setup. Updated it at webpack/webpack#18981.
The test only run under node22+ while we're still using 18. I tested it locally.
Checklist