fix: resolve the inconsistent type issue in JsModule
#8939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #8939 will not alter performanceComparing Summary
|
SoonIter
approved these changes
Jan 7, 2025
SoonIter
previously approved these changes
Jan 7, 2025
| set(val: string) { | ||
| module.userRequest = val; | ||
| set(val: string | undefined) { | ||
| if (val) { |
There was a problem hiding this comment.
what if val is an empty string ''?
There was a problem hiding this comment.
The userRequest property exists only when the module is a NormalModule; it does not exist in other cases. When the userRequest of a NormalModule is an empty string (''), it might overlap in meaning with cases where the userRequest is absent in non-NormalModule instances. I am uncertain whether this change is appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8937
Checklist