Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Mask color of image preview should be dark in dark mode #730

Closed
xalanq opened this issue Mar 7, 2024 · 4 comments
Closed

[Feature]: Mask color of image preview should be dark in dark mode #730

xalanq opened this issue Mar 7, 2024 · 4 comments
Labels
💡 feature

Comments

@xalanq
Copy link
Contributor

xalanq commented Mar 7, 2024

What problem does this feature solve?

When user click the image, the mask color of image preview should be dark instead of light.

image

What does the proposed API look like?

None
@sanyuan0704
Copy link
Contributor

Yeah, i also notice the detail. Are you interested in solving the problem?

@xalanq
Copy link
Contributor Author

xalanq commented Mar 7, 2024

Yeah, i also notice the detail. Are you interested in solving the problem?

ok, I'll make a PR.

xalanq added a commit to xalanq/rspress that referenced this issue Mar 7, 2024
@xalanq
feat(plugin-medium-zoom): set mask color of image preview to be black…
ceeadce 
… #000 in dark mode (web-infra-dev#730)
xalanq added a commit to xalanq/rspress that referenced this issue Mar 7, 2024
@xalanq
feat(plugin-medium-zoom): set mask color of image preview to be black…
52e7ac5 
… #000 in dark mode (web-infra-dev#730)
@xalanq xalanq mentioned this issue Mar 7, 2024
Merged
3 tasks
@xalanq
Copy link
Contributor Author

xalanq commented Mar 12, 2024

@sanyuan0704 How about #732, is that ok?

@sanyuan0704
Copy link
Contributor

@sanyuan0704 How about #732, is that ok?

Thank you, i have commented on this pr.

xalanq added a commit to xalanq/rspress that referenced this issue Mar 12, 2024
@xalanq
feat: set mask color of image preview to be black #000 in dark mode (w…
2c22e5d 
…eb-infra-dev#730)
xalanq added a commit to xalanq/rspress that referenced this issue Mar 12, 2024
@xalanq
feat: set mask color of image preview to be black #000 in dark mode (w…
705735b 
…eb-infra-dev#730)
sanyuan0704 pushed a commit that referenced this issue Mar 12, 2024
@xalanq
feat: set mask color of image preview to be black #000 in dark mode (#…
e3359be 
…730) (#732)
This was referenced Mar 14, 2024
Closed
Merged
@xalanq xalanq closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xalanq @sanyuan0704