fix: crash when page not found & using multiVersion #1007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
same as #987
When using
multiVersion
, theuseNav
hook defaults to 'default' version when version fromuseVersion
is empty. We should first check for defaultVersion insiteData.multiVersion.default
before going withdefault
as a key for nav.Edit: as this happens on 404 page only, it's better to supply
defaultVersion
fromsiteData.multiVersion.default
ininitPageData
, similar as it is done for lang. This ensured that:multiVersion
setupsearch.versioned
, fetching search index doesn't fail, and fetches default version indexRelated Issue
closes #986
Checklist