feat: better gracefully shutdown #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Jun 27, 2024
Timeless0911
force-pushed
the
chore/gracefully-shhutdown
branch
from
8dd989d to
e732da9
Compare
Timeless0911
changed the title
chenjiahan
approved these changes
Jun 27, 2024
9aoy
reviewed
Jun 27, 2024
| @@ -100,9 +100,14 @@ cli | |||
| await startDevServer(); | |||
|
|
|||
| const exitProcess = async () => { | |||
There was a problem hiding this comment.
shall we add a timeout to force exit after 5 seconds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Actively exit the process when gracefully shutdown.
Related Issue
Checklist