Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): upgrade flexsearch 0.7 and adopt the new API design #1294

Merged
merged 7 commits into from
Aug 2, 2024
Merged

feat(search): upgrade flexsearch 0.7 and adopt the new API design #1294

merged 7 commits into from
Aug 2, 2024

Conversation

zoolsher
Copy link
Contributor

@zoolsher zoolsher commented Aug 1, 2024

Summary

flexsearch 0.7.x designed new API for document search this commit adopted the new API

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@zoolsher zoolsher requested a review from Timeless0911 August 1, 2024 14:51
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit f7ecfd5
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66ac7ef4ff387600087f9f75
😎 Deploy Preview https://deploy-preview-1294--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zoolsher zoolsher force-pushed the feat/upgrade-flexsearch branch from 9f0254b to 4253686 Compare August 1, 2024 15:46
@zoolsher zoolsher force-pushed the feat/upgrade-flexsearch branch from 4253686 to 4cb5152 Compare August 1, 2024 15:47
@zoolsher zoolsher requested review from chenjiahan and SoonIter August 1, 2024 15:51
@chenjiahan chenjiahan changed the title chore(search): upgrade flexsearch and adopt the new API design feat(search): upgrade flexsearch 0.7 and adopt the new API design Aug 2, 2024
chenjiahan
chenjiahan previously approved these changes Aug 2, 2024
View reviewed changes
@zoolsher zoolsher enabled auto-merge (rebase) August 2, 2024 06:40
@zoolsher zoolsher merged commit eca76c9 into main Aug 2, 2024
7 checks passed
@zoolsher zoolsher deleted the feat/upgrade-flexsearch branch August 2, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@Timeless0911 Timeless0911 Awaiting requested review from Timeless0911

@SoonIter SoonIter Awaiting requested review from SoonIter

Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoolsher @chenjiahan @Timeless0911